feat(prose): update code element styling; cleanup #2174
Merged
+376
−183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 49bceb1 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for stacks ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for stacks-svelte ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
CGuindon
approved these changes
Feb 6, 2026
giamir
approved these changes
Feb 9, 2026
Contributor
giamir
left a comment
giamir
left a comment
There was a problem hiding this comment.
Looks good, @dancormier. Let's add new: true to the prose item in site-navigation.json. This will show the activity indicator and keep it consistent with the other components we’ve updated. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SPARK-171
This PR updates the Prose component to the latest SHINE styles. It also removes
xsandmdsizes, adds a11y + visual tests, and removes the rounded corners from<code>elements.Note
This PR does not include a Svelte Prose component since it would really just be
<article class="s-prose">{@render children()}</article>.